Skip to content

Add setAutoscaleDisabled API to provide a better means to disabling autoscaling at widget level #2863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
amartya4256 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add setAutoscaleDisabled API to provide a better means to disabling autoscaling at widget level #2863

amartya4256 wants to merge 1 commit into from
+31 −16

Conversation

@amartya4256
Copy link
Contributor

@amartya4256 amartya4256 commented Dec 9, 2025 •
edited
Loading

This PR provides a new API setAutoscaleDisabled to provide a better means of disabling autoscaling at widget level across all the platforms. The current implementation is intended to return a false when this method is called in cocoa and GTK and only perform an action win32 and return since we do not support widget level autoscaling control on GTK and cocoa yet.

The convention of the method is as follows:

  1. Takes a boolean parameter for disabling or enabling autoscale
  2. returns true if successful (in case of win32) otherwise false (in case of GTK and cocoa)

Things to be done:

  • Usage of different autoscaling modes as enabled, disabled and disabled_cascaded, etc
  • Testing with GEF to see how it impacts.

@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Dec 9, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF

Warning

🚧 This PR cannot be modified by maintainers because edits are disabled or it is created from an organization repository. To obtain the required changes apply the git patch manually as an additional commit.

Git patch 
From 4deea7c866d12ffa38192ff0ca7a6b21dae06d92 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Tue, 9 Dec 2025 13:14:31 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF b/binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF
index 84f618f2b6..3dccebb562 100644
--- a/binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF
+++ b/binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Fragment-Host: org.eclipse.swt;bundle-version="[3.128.0,4.0.0)"
 Bundle-Name: %fragmentName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.swt.win32.win32.x86_64; singleton:=true
-Bundle-Version: 3.132.0.qualifier
+Bundle-Version: 3.132.100.qualifier
 Bundle-ManifestVersion: 2
 Bundle-Localization: fragment
 Export-Package: 
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Test Results

  166 files   - 10    166 suites   - 10   14m 32s ⏱️ - 14m 8s
4 613 tests  - 57  4 393 ✅  - 255  220 💤 +198  0 ❌ ±0 
  424 runs   - 57    421 ✅  -  54    3 💤  -   3  0 ❌ ±0 

Results for commit 8127aea. ± Comparison against base commit fb71f1f.

This pull request removes 57 tests. 
AllWin32Tests ImageWin32Tests ‑ testDisposeDrawnImageBeforeRequestingTargetForOtherZoom
AllWin32Tests ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[1] true
AllWin32Tests ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[2] false
AllWin32Tests ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
AllWin32Tests ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
AllWin32Tests ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[1] true
AllWin32Tests ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[2] false
AllWin32Tests ImageWin32Tests ‑ test_getImageData_fromCopiedImage
AllWin32Tests ImageWin32Tests ‑ test_getImageData_fromImageForImageDataFromImage
AllWin32Tests TestTreeColumn ‑ test_ColumnOrder
…
This pull request skips 201 tests. 
org.eclipse.swt.tests.junit.DPIUtilTests ‑ scaleDownFloat
org.eclipse.swt.tests.junit.DPIUtilTests ‑ scaleUpInteger
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_BrowserFunction_callback_stackedCalls
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_Constructor_multipleInstantiationsInDifferentThreads
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser_IE ‑ test_BrowserFunction_callback
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser_IE ‑ test_BrowserFunction_callback_afterPageReload
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser_IE ‑ test_BrowserFunction_callback_stackedCalls
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser_IE ‑ test_BrowserFunction_callback_with_String
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser_IE ‑ test_BrowserFunction_callback_with_boolean
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser_IE ‑ test_BrowserFunction_callback_with_integer
…

@HeikoKlare
Copy link
Contributor

HeikoKlare commented Dec 9, 2025

@amartya4256 can you please add a meaningful title and description to the PR, even if it's still a draft?

@amartya4256 amartya4256 changed the title WIP Add setAutoscaleDisabled API to provide a better means to disabling autoscaling at widget level Dec 9, 2025
@amartya4256 amartya4256 linked an issue Dec 9, 2025 that may be closed by this pull request
Wrong zoom taken for system metrics in autoscale-disabled controls/scrollables vi-eclipse/Eclipse-Platform#546
Open
@arunjose696 arunjose696 mentioned this pull request Dec 17, 2025
Open
@akoch-yatta akoch-yatta removed a link to an issue Dec 19, 2025
Wrong zoom taken for system metrics in autoscale-disabled controls/scrollables vi-eclipse/Eclipse-Platform#546
Open
@amartya4256 amartya4256 linked an issue Dec 19, 2025 that may be closed by this pull request
[Concept] Proper implementation of autoscale disablement for part of the application vi-eclipse/Eclipse-Platform#345
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Concept] Proper implementation of autoscale disablement for part of the application

3 participants

@amartya4256 @eclipse-platform-bot @HeikoKlare